test: add regression test for minimum handle length#377
Merged
Conversation
|
@shadrach68 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds regression testing to cover the minimum boundary of the handle validation during creator registration. While the maximum and empty-string boundaries were previously tested, this ensures that the shortest allowed handle is accepted without error.
Changes
HANDLE_LEN_MINcharacters and asserts that the registration succeeds and the state is updated correctly.HANDLE_LEN_MIN - 1characters and asserts it is cleanly rejected withContractError::HandleTooShort.HANDLE_LEN_MINconstant directly from the contract to size the byte arrays dynamically, avoiding hardcoded values.Related Issues
Closes #367
Checklist
contract_test_envhelpers where possible.cargo test --workspacelocally.